[EuiTable][EuiBasicTable][EuiInMemoryTable] Remove responsive prop completely in favor of responsiveBreakpoint#7633
Merged
cee-chen merged 2 commits intoelastic:tableflipfrom Mar 29, 2024
Conversation
- instead of deprecating it - might as well since we're already breaking a bunch of other table props, and conversion for `={false}` usage is just a prop name change
+ update changelog section with a section specifically for DOM
cee-chen
added
the
breaking change
|
This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:
|
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
|
Member
|
I agree, I think the move directly to the breaking change without a lengthy deprecation here is fine. As you mentioned, we're making a bunch of other breaking changes anyway, and the level of effort here for a consumer to switch props should be low. |
JasonStoltz
approved these changes
Mar 29, 2024
cee-chen
added a commit
that referenced
this pull request
Apr 1, 2024
…completely in favor of `responsiveBreakpoint` (#7633)
cee-chen
added a commit
that referenced
this pull request
Apr 5, 2024
…completely in favor of `responsiveBreakpoint` (#7633)
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I figured since we're already breaking/removing table props in #7632 and we're going to have to update a bunch of Kibana usages anyway, I should go ahead and just remove the
responsiveprop entirely that was only deprecated in #7625.Typescript will help us catch most of these, but here's a quick list from searching (~10 found instances):
responsive={false}QA
QA will not look entirely correct until all Sass styles have been converted to Emotion. Also, QA should have already occurred as part of #7625 / will have another pass in the final feature branch
General checklist
@defaultif default values are missing) and playground toggles